[rush-migrate-subspace-plugin]: add clean subspace feature #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-gomes-92
force-pushed
the
pedrogomes/support-clean-subspace
branch
from
c0eb143 to
aeaa914
Compare
pedro-gomes-92
changed the title
octogonz
reviewed
Dec 20, 2024
octogonz
reviewed
Dec 20, 2024
rush-plugins/rush-migrate-subspace-plugin/src/prompts/subspace.ts
Outdated
Show resolved
Hide resolved
octogonz
reviewed
Dec 20, 2024
rush-plugins/rush-migrate-subspace-plugin/src/utilities/project.ts
Outdated
Show resolved
Hide resolved
octogonz
reviewed
Dec 20, 2024
octogonz
reviewed
Dec 20, 2024
octogonz
reviewed
Dec 20, 2024
octogonz
reviewed
Dec 20, 2024
octogonz
reviewed
Dec 20, 2024
| const devDependencies: string[] = Object.keys(projectPackageJson.devDependencies || {}); | ||
|
|
||
| devDependencies.forEach((devDependency) => { | ||
| if (dependencies.includes(devDependency)) { |
There was a problem hiding this comment.
It is valid to declare something like this:
"dependencies": {
"thing": "^1.0.0" // people who install my project can use the latest 1.x
},
"devDependencies": {
"thing": "1.2.3" // but for development, I want the specific version 1.2.3
},There was a problem hiding this comment.
@octogonz I understand your point, but for the sake of cleaning a subspace dependency tree, don't you think it is more beneficial for a package to keep 1 standard version instead of multiple possible versions?
In other words, what is the benefit for developers and users to use 2 different versions of "thing", which can lead to different results (and even issues that might not be tracked during development)?
octogonz
reviewed
Dec 20, 2024
rush-plugins/rush-migrate-subspace-plugin/src/utilities/project.ts
Outdated
Show resolved
Hide resolved
octogonz
reviewed
Dec 20, 2024
octogonz
approved these changes
Dec 20, 2024
Co-authored-by: Pete Gonzalez <[email protected]>
Co-authored-by: Pete Gonzalez <[email protected]>
pedro-gomes-92
force-pushed
the
pedrogomes/support-clean-subspace
branch
from
82ee097 to
b372387
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Checks
Have you run
rush changefor this change?If No, please run
rush changebefore, this is necessary.If adding a new feature, the PR's description includes:
Reason for adding this feature
A lot of subspaces are not being properly managed, where there are a lot of similar, duplicated or unused dependency versions being added to the "common-versions.json". Adding this feature helps developers to rapidly clean their subspace multiple dependency versions, reducing its "pnpm-lock.yaml" file and minimise future issues.
How to use
Does this PR introduce a breaking change? (check one)
Summary
Supports the parameter --clean, to remove a subspace unnecessary dependency versions, reducing its "pnpm-lock.yaml" file and prevent future dependency issues.
Detail